Allow custom multiblocks to have a custom CrafterComponent #1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckEntity, add onCraft to CrafterComponent
|
Oh so you're writing an addon? Is it public yet? |
Technici4n
reviewed
Jul 16, 2025
src/main/java/aztech/modern_industrialization/machines/components/CrafterComponent.java
Outdated
Show resolved
Hide resolved
Hopefully I can get it out this month 🙂 |
Technici4n
reviewed
Jul 17, 2025
...ustrialization/machines/blockentities/multiblocks/AbstractCraftingMultiblockBlockEntity.java
Outdated
Show resolved
Hide resolved
Technici4n
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AbstractCraftingMultiblockBlockEntityimplementsCrafterComponentHolder, but directly accessescrafterinstead of callinggetCrafterComponentontick, meaning any implementing classes are unable to have a customCrafterComponent.Solution
All direct accesses to
crafterontickare replaced bygetCrafterComponent. This PR also includes a new method calledonCraftthat allows customCrafterComponents to detect when a recipe is completed without overriding/mixin injectingtickRecipe.Use case
Imagine a machine that alters the non-consumed input stack in some way (i.e. one of its data components' value). If said way is not recipe dependent,
CrafterComponentis the most sensible place to modify it.